Default to XorCsrfChannelInterceptor in XML configuration #17323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: config
|
@msqr, thanks for the PR. I'm seeing some errors in the build that appear unrelated to your PR; however, I'm having trouble rebasing your PR to the latest. Will you please pull the latest |
jzheaux
added
the
status: waiting-for-feedback
Change WebSocketMessageBrokerSecurityBeanDefinitionParser to use XorCsrfChannelInterceptor by default, so WebSocket XML configuration matches the default Xor-based configuration already in WebSocketMessageBrokerSecurityConfiguration. Issue spring-projectsgh-17260 Signed-off-by: Matt Magoffin <[email protected]>
msqr
force-pushed
the
feature/websocket-xml-config-xor-csrf
branch
from
8aa15bb to
8e7101d
Compare
|
Sure thing @jzheaux I've done that now. It built and all tests ran successfully for me locally after the rebase. |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change WebSocketMessageBrokerSecurityBeanDefinitionParser to use XorCsrfChannelInterceptor by default, so WebSocket XML configuration matches the default Xor-based configuration already in WebSocketMessageBrokerSecurityConfiguration.
Issue gh-17260